[PATCH] D79276: [FileCheck] Support comment directives

Mon May 4 09:05:12 PDT 2020

jdenny added a comment.

In D79276#2017742 <https://reviews.llvm.org/D79276#2017742>, @jdenny wrote:

> Thanks for the review.  I've replied to a few comments, and I'll address the rest later.
>
> In D79276#2017101 <https://reviews.llvm.org/D79276#2017101>, @jhenderson wrote:
>
> > I hesitate to suggest this, but is it worth using `REM` as a comment prefix? It's the comment marker for Windows batch files, so has some precedence.
>
>
> I don't have a strong preference.  Does anyone else following this have a preference?

One reason not to choose `REM:` is that it looks much more like `RUN:` than `COM:`.  For example, imagine the long code sample I wrote in my last comment <https://reviews.llvm.org/D79276#inline-726677>, but with `COM:` replaced by `REM:`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79276/new/

https://reviews.llvm.org/D79276