[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 2 08:27:47 PDT 2020


aaron.ballman added a comment.

I only see a comment on the issue, but not that the issue was resolved in favor of that comment (unless I've missed something). If the issue gets resolved in the direction that comment is going, then the revert makes sense (though we should add an explicit test case showing that we want the diagnostic).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79113/new/

https://reviews.llvm.org/D79113





More information about the cfe-commits mailing list