[PATCH] D74051: Move update_cc_test_checks.py tests to clang

[Alexander Richardson via Phabricator via cfe-commits]

arichardson added a comment.

In D74051#2016101 <https://reviews.llvm.org/D74051#2016101>, @mgorny wrote:

> In D74051#2016085 <https://reviews.llvm.org/D74051#2016085>, @lebedev.ri wrote:
>
> > In D74051#2016078 <https://reviews.llvm.org/D74051#2016078>, @mgorny wrote:
> >
> > > This broke running clang tests stand-alone:
> > >
> > >   Traceback (most recent call last):
> > >     File "/var/tmp/portage/sys-devel/clang-11.0.0.9999/work/x/y/clang-abi_x86_64.amd64/bin/../../llvm/utils/lit/lit/TestingConfig.py", line 89, in load_from_path
> > >       exec(compile(data, path, 'exec'), cfg_globals, None)
> > >     File "/var/tmp/portage/sys-devel/clang-11.0.0.9999/work/x/y/clang/test/utils/update_cc_test_checks/lit.local.cfg", line 21, in <module>
> > >       assert os.path.isfile(script_path)
> > >   AssertionError
> > >                                                             
> > >   FAILED: test/CMakeFiles/check-clang
> > >  
> > >
> > >
> > > Obviously this fails when LLVM source tree is not available.
> >
> >
> > Is that a supported build mode for clang?
>
>
> Yes, and I don't see why that would change today.
>
> > 
> > 
> >> If this is used only in clang, the script should be moved to clang as well.
> > 
> > I was under impression that it is exactly what this change did.
>
> My bad. In that case, the path needs to be updated to refer to clang source tree and not llvm's.


The update_cc_test_checks.py script depends on files in llvm/utils/UpdateTestChecks, so moving the script to clang doesn't help.
I assumed that having clang as part of the monorepo meant llvm would be available.
I building a tarball of only the clang source directory is supported, then we should skip the clang/tests/utils/update_cc_test_checks tests subdirectory if LLVM sources are not available.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74051/new/

https://reviews.llvm.org/D74051