[PATCH] D79087: [SVE][Codegen] Lower legal min & max operations

Fri May 1 17:13:44 PDT 2020

kmclaughlin marked an inline comment as done.
kmclaughlin added inline comments.

================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:3851
+  def : SVE_1_Op_Imm_Arith_Pred_Pat<nxv4i32, nxv4i1,  op, ZPR32, i32, SVEArithSImmPat, !cast<Instruction>(NAME # _S)>;
+  def : SVE_1_Op_Imm_Arith_Pred_Pat<nxv2i64, nxv2i1,  op, ZPR64, i64, SVEArithSImmPat, !cast<Instruction>(NAME # _D)>;
 }
----------------
efriedma wrote:
> kmclaughlin wrote:
> > efriedma wrote:
> > > I don't see any test for this part of the patch?
> > The tests for these patterns are in `sve-int-arith-imm.ll`, which was added as part of D71779
> I'd also like to see tests for the intrinsic where the second operand is an immediate, since we can pattern-match that to the immdiate smax now.
I see what you mean now, I've added the intrinsic tests to sve-intrinsics-int-arith-imm.ll

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79087/new/

https://reviews.llvm.org/D79087