[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

[Sam Parker via Phabricator via cfe-commits]

samparker added a comment.

Thanks for adding the MVE changes, but I also still don't see any DSP tests, i.e QADD, SADD16.



================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5753
+  // ahead and skip over them.
+  if (MI.isKill())
+    return outliner::InstrType::Invisible;
----------------
Should IMPLICIT_DEF instructions be considered invisible too?


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5817
+  // Be conservative with program counter.
+  if (MI.readsRegister(ARM::PC, TRI) || MI.modifiesRegister(ARM::PC, TRI))
+    return outliner::InstrType::Illegal;
----------------
Cheers. AArch64 is nice and doesn't allow arbitrary writes to the PC, but we won't have that luxury here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76066/new/

https://reviews.llvm.org/D76066