[PATCH] D78982: [clang-format] Fix Microsoft style for enums
Marek Kurdej via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 30 15:39:09 PDT 2020
curdeius added a comment.
In D78982#2013221 <https://reviews.llvm.org/D78982#2013221>, @RKSimon wrote:
> @asmith I'm seeing MSVC warnings from this patch:
>
> E:\llvm\llvm-project\clang\lib\Format\UnwrappedLineParser.cpp(1475): warning C4305: 'argument': truncation from 'clang::tok::TokenKind' to 'bool'
> E:\llvm\llvm-project\clang\lib\Format\UnwrappedLineParser.cpp(1828): warning C4305: 'argument': truncation from 'clang::tok::TokenKind' to 'bool'
That's caused by the changed signature of `parseBracedList` and this change hasn't been taken into account at the above mentioned locations:
- bool parseBracedList(bool ContinueOnSemicolons = false,
+ bool parseBracedList(bool ContinueOnSemicolons = false, bool IsEnum = false, tok::TokenKind ClosingBraceKind = tok::r_brace);
BTW, it's a bit strange that a new parameter had been added in the middle of parameter list.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78982/new/
https://reviews.llvm.org/D78982
More information about the cfe-commits
mailing list