[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:870
+def err_pragma_fenv_requires_precise : Error<
+  "'#pragma STDC FENV_ACCESS ON' is illegal when precise is disabled">;
 def warn_cxx_ms_struct :
----------------
mibintc wrote:
> erichkeane wrote:
> > The last 4 can be done via selects as well!  Save a couple more spaces before we have to up the diagnostic id size :) 
> > 
> > The last 4 can be done via selects as well
> Combining these 4 into 1 diagnostic is doable but it's ugly.
Concur, I spent some time on it and don't really like it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72841/new/

https://reviews.llvm.org/D72841