[PATCH] D78350: [AST] Build recovery expressions by default for C++.

[Haojian Wu via Phabricator via cfe-commits]

hokein marked an inline comment as done.
hokein added a comment.

In D78350#2009345 <https://reviews.llvm.org/D78350#2009345>, @hubert.reinterpretcast wrote:

> In D78350#2007065 <https://reviews.llvm.org/D78350#2007065>, @hokein wrote:
>
> > In D78350#2006469 <https://reviews.llvm.org/D78350#2006469>, @hubert.reinterpretcast wrote:
> >
> > > Got it. I'll put together a build.
> >
> >
> > Thank you! Look forward to the result. The patch should work on the latest master (b73290be9fa413d8bc426512cdf4fa01bc005954 <https://reviews.llvm.org/rGb73290be9fa413d8bc426512cdf4fa01bc005954>).
>
>
> Looks clean on my end.


Great, thanks!



================
Comment at: clang/include/clang/Basic/LangOptions.def:151
 
-COMPATIBLE_LANGOPT(RecoveryAST, 1, 0, "Preserve expressions in AST when encountering errors")
+COMPATIBLE_LANGOPT(RecoveryAST, 1, CPlusPlus, "Preserve expressions in AST when encountering errors")
 
----------------
rsmith wrote:
> Does this work? I would expect that we set all the options to the defaults at the same time, so this just sets this option to 0 (the default for `CPlusPlus`). If so, it'd be clearer to explicitly write that default here.
I'm following the scheme of other fields, e.g. `WChar`, the real initialization is done in `CompilerInvocation.cpp`. 

I think writing `CPlusPlus` is a bit clearer here, which indicates this option is associated with CPlusPlus flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78350/new/

https://reviews.llvm.org/D78350