[PATCH] D76932: [AIX] emit .extern and .weak directive linkage
Hubert Tong via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 29 14:33:35 PDT 2020
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
LGTM with minor comment.
================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2143
+ case GlobalValue::AvailableExternallyLinkage:
+ report_fatal_error("Unhandled AvailableExternallyLinkage when mapping "
+ "linkage to StorageClass");
----------------
The beginning of `report_fatal_error` messages should not be capitalized in the style of a sentence.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76932/new/
https://reviews.llvm.org/D76932
More information about the cfe-commits
mailing list