[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

Wed Apr 29 12:55:09 PDT 2020

rjmccall added a comment.

In D78785#2010738 <https://reviews.llvm.org/D78785#2010738>, @erichkeane wrote:

> In D78785#2010654 <https://reviews.llvm.org/D78785#2010654>, @rjmccall wrote:
>
> > Every target does something similar, they just all do it in different ways because they're mostly written by different people.
> >
> > We should restrict this feature to targets where we've adequately audited the ABI.  It's not a feature until the ABI work is done.
>
>
> I'm discovering that now :)  I'm currently trying to do said audit by going down the ABIInfo inheritance tree.  I believe we have at least a month until the next release branch date.  If you can help keep me honest here, I'll disable _ExtInt for any platforms I haven't done by then at the branch.
>
> Does that seem acceptable?

Yes, although, I think you ought to flip the default anyway just so we're doing the right thing for out-of-tree targets.  It should then be very straightforward to flip it back target-by-target as you do your audit.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78785/new/

https://reviews.llvm.org/D78785