[PATCH] D78979: OpenCL: Include builtin header by default

Wed Apr 29 12:22:23 PDT 2020

Anastasia added a comment.

In D78979#2007760 <https://reviews.llvm.org/D78979#2007760>, @yaxunl wrote:

> In D78979#2007643 <https://reviews.llvm.org/D78979#2007643>, @Anastasia wrote:
>
> > ah I guess if we leave it under `-cc1 ` we will have the command line interface as follows:
> >
> > - Driver (without `-cc1`) adds OpenCL header by default that can be overridden by the flag added in this patch.
> > - Frontend (with `-cc1`) doesn't add the header by default but there are two flags `-fdeclare-opencl-builtins` or `-finclude-default-header` that allow to include the header.
> >
> >   Is my understanding correct? We should reflect this is the User Manual.
>
>
> I think -finclude-default-header -fno-include-default-header better becomes both driver and -cc1 option since users are likely to use it with driver. It may also be used with other languages e.g. HIP.

If we change `-finclude-default-header` to driver option, what would it do since the header is added by default?

Unless as @arsenm pointed out we want to get rid of custom OpenCL options and just use standard ones for C/C++...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78979/new/

https://reviews.llvm.org/D78979