[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

Wed Apr 29 08:00:57 PDT 2020

kbobyrev added a comment.

In D79085#2010025 <https://reviews.llvm.org/D79085#2010025>, @sammccall wrote:

> Haha, CMake :-(

Now that I know this it kind of makes sense (I guess it's faster to just build everything and then link when all deps are ready), just something I didn't think about :)

================
Comment at: clang-tools-extra/clangd/index/remote/CMakeLists.txt:22
     )
+  add_dependencies(clangdRemoteIndex RemoteIndexProtos)

----------------
sammccall wrote:
> is this equivalent to `DEPENDS RemoteIndexProtos` in the library?
> Slightly clearer probably.
Ah, true, I had a feeling there was something like this on top of my mind, but forgot about `DEPENDS` :) Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79085/new/

https://reviews.llvm.org/D79085