[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

Sander de Smalen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 29 06:24:05 PDT 2020


sdesmalen marked an inline comment as done.
sdesmalen added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880
+    return Builder.CreateBitCast(Val, Ty);
+  }
+
----------------
efriedma wrote:
> I'm vaguely suspicious this might be wrong for big-endian targets.  I mean, this isn't unreasonable, but users might be surprised if svreinterpret isn't a no-op.
For SVE the loads and stores (svld1 and svst1) are all endian safe, so no special consideration needs to be taken for big endian targets.

The ACLE specifies that:
> The svreinterpret functions simply reinterpret a vector of one type as a vector of another type, without changing any of the bits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78756/new/

https://reviews.llvm.org/D78756





More information about the cfe-commits mailing list