[PATCH] D78677: [SveEmitter] Add builtins for gather prefetches

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 28 18:54:59 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7739
+
+    // Index needs to be passed as scaled offset.
+    llvm::Type *MemEltTy = SVEBuiltinMemEltTy(TypeFlags);
----------------
`} else {`, so you aren't multiplying by zero?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78677/new/

https://reviews.llvm.org/D78677





More information about the cfe-commits mailing list