[PATCH] D79054: [NFC] Improve documentation for -i and update example git one liner

Christopher Tetreault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 28 16:45:50 PDT 2020


ctetreau added a comment.

I considered trying to find a way to work around the issue. Something like "if the file is not found, and the current directory is `/foo/bar/`, and the computed filename is `bar/baz.c`, then use `/foo/bar/baz.c`". But I don't think there's any way we can reliably know that such a computed file is correct, and I think it's better to error out than to silently do the wrong thing.

I think the behavior of taking the filename from the diff as-is is reasonable as long as it's documented.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79054/new/

https://reviews.llvm.org/D79054





More information about the cfe-commits mailing list