[PATCH] D78777: [AST] Use PrintingPolicy for format string diagnosis
Jessica Clarke via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 28 16:13:37 PDT 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5fee6936b8b2: [AST] Use PrintingPolicy for format string diagnosis (authored by jrtc27).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78777/new/
https://reviews.llvm.org/D78777
Files:
clang/lib/AST/FormatString.cpp
clang/test/SemaOpenCL/printf-format-strings.cl
Index: clang/test/SemaOpenCL/printf-format-strings.cl
===================================================================
--- clang/test/SemaOpenCL/printf-format-strings.cl
+++ clang/test/SemaOpenCL/printf-format-strings.cl
@@ -65,8 +65,8 @@
kernel void format_v4f16(half4 arg_h, float4 arg_f, double4 arg_d)
{
- printf("%v4hf\n", arg_d); // expected-warning{{format specifies type '__fp16 __attribute__((ext_vector_type(4)))' but the argument has type 'double4' (vector of 4 'double' values)}}
- printf("%v4hf\n", arg_f); // expected-warning{{format specifies type '__fp16 __attribute__((ext_vector_type(4)))' but the argument has type 'float4' (vector of 4 'float' values)}}
+ printf("%v4hf\n", arg_d); // expected-warning{{format specifies type 'half __attribute__((ext_vector_type(4)))' but the argument has type 'double4' (vector of 4 'double' values)}}
+ printf("%v4hf\n", arg_f); // expected-warning{{format specifies type 'half __attribute__((ext_vector_type(4)))' but the argument has type 'float4' (vector of 4 'float' values)}}
printf("%v4hf\n", arg_h);
}
Index: clang/lib/AST/FormatString.cpp
===================================================================
--- clang/lib/AST/FormatString.cpp
+++ clang/lib/AST/FormatString.cpp
@@ -539,7 +539,7 @@
}
std::string ArgType::getRepresentativeTypeName(ASTContext &C) const {
- std::string S = getRepresentativeType(C).getAsString();
+ std::string S = getRepresentativeType(C).getAsString(C.getPrintingPolicy());
std::string Alias;
if (Name) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78777.260793.patch
Type: text/x-patch
Size: 1531 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200428/bbe2f942/attachment.bin>
More information about the cfe-commits
mailing list