[PATCH] D79009: [AST] Preserve the incomplete-type member expr.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 28 13:29:08 PDT 2020


hokein abandoned this revision.
hokein marked an inline comment as done.
hokein added inline comments.


================
Comment at: clang/test/AST/ast-dump-recovery.cpp:107
 
+struct Incomplete;
+Incomplete make_incomplete();
----------------
sammccall wrote:
> This test doesn't seem to relate to member expressions, and passes for me without this patch applied.
oops, sorry, you are right, it works at head (I only verified the test after the patch is applied).

I was confused by a local modification (which preserves type), the recovery-expr `make_incomplete().a` will be dropped because we'll hit the above if statement.  I'dd address this change in preserving-type patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79009/new/

https://reviews.llvm.org/D79009





More information about the cfe-commits mailing list