[PATCH] D79033: [NFC][clang] Replace raw new/delete with unique_ptr to store ABIInfo in TargetCodeGenInfo
Hubert Tong via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 28 12:56:40 PDT 2020
hubert.reinterpretcast added inline comments.
================
Comment at: clang/lib/CodeGen/TargetInfo.h:51
- TargetCodeGenInfo(ABIInfo *info = nullptr) : Info(info) {}
- virtual ~TargetCodeGenInfo();
----------------
I'm not sure removing a virtual destructor is a good idea. The use of `delete` in relation to `TargetCodeGenInfo` (and derived class) pointers would need to be checked.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79033/new/
https://reviews.llvm.org/D79033
More information about the cfe-commits
mailing list