[PATCH] D78979: OpenCL: Include builtin header by default

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

In D78979#2007356 <https://reviews.llvm.org/D78979#2007356>, @Anastasia wrote:

> > I'm somewhat confused by the way this is supposed to work, or why a
> >  separate option exists for OpenCL. The other language flags seem to be
> >  implemented in the driver, not cc1 like OpenCL. I'm not sure this is
> >  the right set of flag naming decisions, or if we really need the
> >  fno-include-default-header cc1 flag.
>
> Originally we didn't want to include the header by default for 2 reasons:
>
> 1. Many vendors used their own header.
> 2. It takes long time to parse the header.


I think this is backwards reasoning. Upstream clang should compile OpenCL as expected by default. If vendors want to use some other header, it should be a downstream responsibility to turn off the default header and include something else


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78979/new/

https://reviews.llvm.org/D78979