[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 28 07:29:18 PDT 2020


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:8
   )
-target_compile_definitions(clangd-index-server PRIVATE -D GOOGLE_PROTOBUF_NO_RTTI=1)
-clang_target_link_libraries(clangd-index-server
----------------
kbobyrev wrote:
> sammccall wrote:
> > why this removal?
> Discussed in the chat.
For the record: redundant with parent package (this is a cleanup-while-here)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78885/new/

https://reviews.llvm.org/D78885





More information about the cfe-commits mailing list