[PATCH] D78979: OpenCL: Include builtin header by default
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 28 06:24:14 PDT 2020
Anastasia added a comment.
>
>
>> I am looping in @svenvh to discuss this further. Sven, do you think we should rename this flag due to current proposed change? Should it be moved out of `-cc1` too?
>
> I would leave `-fdeclare-opencl-builtins` as it is, until it is complete and taken out of its "experimental" status. Then we can discuss if we want to use TableGen instead of the header as a default.
Would it not become confusing since the builtins are going to be included by default? Should we rename the flag at least? Also ideally it should be documented in https://clang.llvm.org/docs/UsersManual.html#opencl-header
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78979/new/
https://reviews.llvm.org/D78979
More information about the cfe-commits
mailing list