[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing
Andi via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 28 02:07:12 PDT 2020
Abpostelnicu added a comment.
In D78879#2004856 <https://reviews.llvm.org/D78879#2004856>, @MyDeveloperDay wrote:
> @sylvestre.ledru , @Abpostelnicu
>
> I believe to fix your original request you need a combination of D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107) <https://reviews.llvm.org/D76850> and this fix (this fix will handle the `* *` issue in `gecko-dev/ipc/mscom/Ptr.h`
>
> I've run this new binary over `gecko-dev/ipc/mscom` and `gecko-dev/xpcom/ds` and it shows no clang-format warnings
>
> I hope this helps
Yes, definitely you are right D76850 <https://reviews.llvm.org/D76850>, only partially fixes the issue introduced by D69573 <https://reviews.llvm.org/D69573>, and your fix it's a good add-on in order to have a complete fix for the regression.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78879/new/
https://reviews.llvm.org/D78879
More information about the cfe-commits
mailing list