[PATCH] D75453: [Driver][ARM] fix undefined behaviour when checking architecture version

Daniel Kiss via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 28 01:34:53 PDT 2020


danielkiss added a comment.

Please update the title and the summary because those will be the commit message.
IMHO the test a case would be extended with a test where the body of the modified if condition is tested.
Otherwise LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75453/new/

https://reviews.llvm.org/D75453





More information about the cfe-commits mailing list