[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

Mon Apr 27 15:39:47 PDT 2020

fpetrogalli added a comment.

Hello reviewers,

I know this is not how the fix should be tested (`fprintf` in debug builds...).

This function would benefit of some unitests in the `unittests` folder of clang, but I don't have a way to export it there as it is private to this module.

I would like to lift it to some class (as a static function of `CodeGenFunction`, for example), but that would require exposing the  `ParamAttrTy`. Are you OK with that? I'd rather use the `llvm::VFParameter` of `llvm/Analisys/VectorUtils.h` as I suggested in http://lists.llvm.org/pipermail/llvm-dev/2020-April/141057.html, but that would definitely require a first patch work to remove the uses of `ParamAttrTy` in favor of `llvm::VFParameter`.

I am open to alternative suggestions, of course!

Kind regards,

Francesco

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78969/new/

https://reviews.llvm.org/D78969