[PATCH] D78938: Fixing all comparisons for C++20 compilation.

Barry Revzin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 27 15:39:47 PDT 2020


BRevzin marked 2 inline comments as done.
BRevzin added inline comments.


================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:69-70
+  }
   bool operator==(OpenMPDirectiveKind V) const { return Value == unsigned(V); }
   bool operator!=(OpenMPDirectiveKind V) const { return Value != unsigned(V); }
   bool operator<(OpenMPDirectiveKind V) const { return Value < unsigned(V); }
----------------
rsmith wrote:
> Do we still need these?
Yep. This type is compared to both itself and the enum, so both are necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78938/new/

https://reviews.llvm.org/D78938





More information about the cfe-commits mailing list