[PATCH] D78760: Check a class has a definition before iterating over its base classes

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 27 15:39:44 PDT 2020


jkorous added a comment.

In D78760#2003118 <https://reviews.llvm.org/D78760#2003118>, @rsmith wrote:

> If so, we'll need to make sure that all code that iterates over base classes checks for this condition (I bet there are more cases than the two that you found).


Just a potentially related thought: I was recently trying to understand under what circumstances should I expect `CXXBaseSpecifier::getType()` to return `QualType` instance for which `isNull()` could be `true`. I gave up and don't make any assumption.
Would the suggested change affect this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78760/new/

https://reviews.llvm.org/D78760





More information about the cfe-commits mailing list