[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

Adrian McCarthy via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 27 10:12:04 PDT 2020


amccarth added a comment.

In D78508#2005311 <https://reviews.llvm.org/D78508#2005311>, @aaron.ballman wrote:

> Personally, I don't consider those to be useless casts. They appropriately ensure that the types match between the arguments and the format specifiers, rather than relying on underlying details of what SIZE_T expands to for a given target. I would expect these to at least use the `warn_format_conversion_argument_type_mismatch_confusion` diagnostic rather than be silenced entirely.


+1.  This is useful to anyone trying to write code that compiles for both 32- and 64-bit code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78508/new/

https://reviews.llvm.org/D78508





More information about the cfe-commits mailing list