[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

[Nico Weber via Phabricator via cfe-commits]

thakis added inline comments.


================
Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101
       // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD.
-      if (!Arg.startswith("-M")) {
+      if (!Arg.startswith("-M") && Arg != "/showIncludes") {
         AdjustedArgs.push_back(Args[i]);
----------------
kadircet wrote:
> aeubanks wrote:
> > kadircet wrote:
> > > kadircet wrote:
> > > > this can also be --show-includes
> > > and looks like there's also `/showIncludes:user` :/
> > Handled `/showIncludes:user`, thanks for catching that. I don't see `--show-includes` though, clang-cl and clang both don't like the option?
> ah sorry, that one is a frontend option rather than a driver one. so nvm that one.
clang-cl suports both /foo and -foo style flags. See the top of clang/include/clang/Driver/CLCompatOptions.td

You probably want to add the -showIncludes prefix here too. Ideally this probably wouldn't do its own commandline parsing here (?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78836/new/

https://reviews.llvm.org/D78836