[PATCH] D78190: Add Bfloat IR type

Mon Apr 27 08:34:38 PDT 2020

stuij marked 8 inline comments as done.
stuij added inline comments.

================
Comment at: llvm/include/llvm-c/Core.h:149
   LLVMHalfTypeKind,        /**< 16 bit floating point type */
+  LLVMBfloatTypeKind,      /**< 16 bit brain floating point type */
   LLVMFloatTypeKind,       /**< 32 bit floating point type */
----------------
scanon wrote:
> Throughout this, I think `BFloat` would be more consistent with other types than `Bfloat` is.
Agreed. I continued the convention of the bfloat C type patch, but it did subconsciously grate a bit. I capitalized it everywhere where the B is capitalized.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78190/new/

https://reviews.llvm.org/D78190