[PATCH] D78762: build: use `find_package(Python3)` if available

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 27 08:34:36 PDT 2020


ldionne accepted this revision.
ldionne added a comment.

In D78762#2002305 <https://reviews.llvm.org/D78762#2002305>, @JDevlieghere wrote:

> My suggestion is to have 4 new CMake variable that abstract over this: `LLVM_PYTHON_EXECUTABLE`, `LLVM_PYTHON_LIBRARIES`, `LLVM_PYTHON_INCLUDE_DIRS` and finally `LLVM_PYTHON_HINT`.  We can then populate the first three depending on what machinery we want to use, i.e. the old CMake way of finding Python (until we bump the requirement across llvm), as well as the new `FindPython3` and `FindPython2`. Similarly for the `HINT` variable, having our own abstraction means we don't clobber any of the variables used internally by CMake.
>
> What do you think?


This is not better IMHO since it assumes that all subprojects are using the `LLVM_meow` variable to refer to the Python executable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78762/new/

https://reviews.llvm.org/D78762





More information about the cfe-commits mailing list