[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

Mon Apr 27 03:43:00 PDT 2020

kadircet marked an inline comment as done.
kadircet added inline comments.

================
Comment at: clang-tools-extra/clangd/Preamble.h:115
+  /// mutate include depths.
+  void patchPreambleIncludes(IncludeStructure &BaselineIncludes) const;
+
----------------
i am not happy about this interface. I was thinking about a `std::vector<Inclusion> remainingBaselineIncludes() const` but didn't go for it to keep the concept of `patching`.

I suppose the former is more intuitive though, WDYT?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77644/new/

https://reviews.llvm.org/D77644