[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

Nemanja Ivanovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 26 18:35:20 PDT 2020


nemanjai marked an inline comment as done.
nemanjai added inline comments.


================
Comment at: clang/lib/Basic/Targets/PPC.h:277
       break;
     case 'Q': // Memory operand that is an offset from a register (it is
               // usually better to use `m' or `es' in asm statements)
----------------
amyk wrote:
> Just curious, but does this case still require `Info.setAllowsMemory();` as well?
I don't want to change the behaviour of a QPX-specific asm constraint, so I'd rather leave it as-is. `Q` will set both, `Z` will only set "memory".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77542/new/

https://reviews.llvm.org/D77542





More information about the cfe-commits mailing list