[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 26 16:28:07 PDT 2020


kbobyrev created this revision.
kbobyrev added a reviewer: sammccall.
Herald added subscribers: llvm-commits, cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny.
Herald added projects: clang, LLVM.

Generated Protobuf library has to be in CLANG_EXPORTS and should also be
installed appropriately. The easiest way to do that is via CMake's
add_clang_library. That unfortunately applies "one directory - one
clang_(library|tool)" policy so .proto files should be in a separate directory
and complicates the layout.

This setup works both in shared and static libs mode.

Resolves: https://github.com/clangd/clangd/issues/351


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78885

Files:
  clang-tools-extra/clangd/index/remote/CMakeLists.txt
  clang-tools-extra/clangd/index/remote/Index.proto
  clang-tools-extra/clangd/index/remote/protos/CMakeLists.txt
  clang-tools-extra/clangd/index/remote/protos/Index.proto
  llvm/cmake/modules/FindGRPC.cmake

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78885.260186.patch
Type: text/x-patch
Size: 3551 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200426/fd71fe77/attachment-0001.bin>


More information about the cfe-commits mailing list