[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 25 09:00:41 PDT 2020


aeubanks marked an inline comment as done.
aeubanks added inline comments.


================
Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101
       // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD.
-      if (!Arg.startswith("-M")) {
+      if (!Arg.startswith("-M") && Arg != "/showIncludes") {
         AdjustedArgs.push_back(Args[i]);
----------------
kadircet wrote:
> kadircet wrote:
> > this can also be --show-includes
> and looks like there's also `/showIncludes:user` :/
Handled `/showIncludes:user`, thanks for catching that. I don't see `--show-includes` though, clang-cl and clang both don't like the option?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78836/new/

https://reviews.llvm.org/D78836





More information about the cfe-commits mailing list