[PATCH] D78843: [clangd] Remove unused bits after 67b2dbd5a33583. NFC
Kirill Bobyrev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 24 18:26:07 PDT 2020
kbobyrev added inline comments.
================
Comment at: clang-tools-extra/clangd/Features.inc.in:2
#define CLANGD_BUILD_XPC @CLANGD_BUILD_XPC@
-#define CLANGD_ENABLE_REMOTE @CLANGD_ENABLE_REMOTE@
----------------
I don't know how much code will have with `ifdefs` in the Clangd itself, but I can think of several places, so I'm not sure whether removing this is really needed (since I'd most likely add this back in the next patch or two). However, I'm OK with doing that, things might change.
The cleanup which will be correct regardless is removing the last implicit remnants of `CLANGD_ENABLE_REMOTE` from Dexp:
* `Features.in` include is no longer needed
* CMake's directive to include the directory with `Features.in` is also no longer needed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78843/new/
https://reviews.llvm.org/D78843
More information about the cfe-commits
mailing list