[PATCH] D76452: Use LLD by default for Android.

Fri Apr 24 16:18:20 PDT 2020

danalbert abandoned this revision.
danalbert added a comment.

In D76452#2002917 <https://reviews.llvm.org/D76452#2002917>, @MaskRay wrote:

> In D76452#2002875 <https://reviews.llvm.org/D76452#2002875>, @danalbert wrote:
>
> > In D76452#2002856 <https://reviews.llvm.org/D76452#2002856>, @int3 wrote:
> >
> > > Yes, I was referring to that question too :) I'm working on the new lld-macho implementation, under the `DarwinNew` flavor. I'm not sure if anything depends on the old `Darwin` flavor, which is why we haven't removed it yet, though we plan to do that once we get the new implementation to a more mature stage.
> >
> >
> > Ah, gotcha :) Thanks! Will wait for @ruiu to chime in.
>
>
> I vote for deleting the `#ifdef __APPLE__` chunk so we don't have to add more code to either clang or lld....
>  The code owner of the existing lld darwin has explicitly expressed that we can drop the existing `Darwin` flavor at any time.

SGTM. Abandoning this. I'll send a patch to remove the LLD side shortly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76452/new/

https://reviews.llvm.org/D76452