[PATCH] D76452: Use LLD by default for Android.

Dan Albert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 24 14:39:53 PDT 2020


danalbert added a comment.

In D76452#2002620 <https://reviews.llvm.org/D76452#2002620>, @int3 wrote:

> I don't think I have enough context here to answer the question, but I'm pretty sure that change wouldn't affect what I'm working on


Sorry, wasn't referring to that question specifically, but the LLD one that @MaskRay CC'd you for a little further up.

> But hope @ruiu or @int3 can clarify that we can't get rid of the __APPLE__ special case in:
> 
>   // lld/tools/lld/lld.cpp
>   static Flavor parseProgname(StringRef progname) {
>   #if __APPLE__
>     // Use Darwin driver for "ld" on Darwin.
>     if (progname == "ld")
>       return Darwin;
>   #endif
>   
>   #if LLVM_ON_UNIX
>     // Use GNU driver for "ld" on other Unix-like system.
>     if (progname == "ld")
>       return Gnu;
>   #endif


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76452/new/

https://reviews.llvm.org/D76452





More information about the cfe-commits mailing list