[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 24 10:16:08 PDT 2020
rjmccall added a comment.
LGTM with one very minor fix.
================
Comment at: clang/docs/LanguageExtensions.rst:511
+ *r = *a + (*b * *c);
+ }
+
----------------
fhahn wrote:
> rjmccall wrote:
> > This is kindof an unnecessarily unreadable example. I know you haven't decided on calling convention treatment yet, but maybe the leading example could be just a little ahead of the implementation and just take the matrices as arguments and then return the result.
> I wasn't sure if that would be fine, but it indeed makes things much more readable. Updated.
Extra space after the `+`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76612/new/
https://reviews.llvm.org/D76612
More information about the cfe-commits
mailing list