[PATCH] D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 24 06:59:41 PDT 2020


Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/MapSubscriptOperatorLookupCheck.cpp:31
+void MapSubscriptOperatorLookupCheck::registerMatchers(MatchFinder *Finder) {
+  if (!getLangOpts().CPlusPlus)
+    return;
----------------
Should be in isLanguageVersionSupported() method.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:78
 ^^^^^^^^^^
+- New :doc:`bugprone-map-subscript-operator-lookup
+  <clang-tidy/checks/bugprone-map-subscript-operator-lookup>` check.
----------------
Please separate with empty line.


================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:81
+
+  Detects map lookups done with operator[].
+
----------------
Please synchronize with first statement in documentation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D46317/new/

https://reviews.llvm.org/D46317





More information about the cfe-commits mailing list