[PATCH] D78655: [HIP] Let lambda be host device by default

Paul Fultz II via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 23 19:34:43 PDT 2020


pfultz2 added inline comments.


================
Comment at: clang/lib/Sema/SemaCUDA.cpp:723
+    Method->addAttr(CUDADeviceAttr::CreateImplicit(Context));
+    Method->addAttr(CUDAHostAttr::CreateImplicit(Context));
+    return;
----------------
Shouldn't we add these attributes if there are no host and device attributes? This seems like it will treat `[]() __device__ {}` as host device.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78655/new/

https://reviews.llvm.org/D78655





More information about the cfe-commits mailing list