[PATCH] D78674: [SveEmitter] Add builtins for contiguous prefetches

[Eli Friedman via Phabricator via cfe-commits]

efriedma accepted this revision.
efriedma added a comment.

LGTM



================
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_prfb.c:22
+  // expected-error at +1 {{argument value -1 is outside the valid range [0, 13]}}
+  return svprfb(pg, base, -1);
+}
----------------
sdesmalen wrote:
> efriedma wrote:
> > Maybe worth adding a negative test for svprfb_vnum?
> Yes good catch I've added them. I'm not necessarily sure we also need to add them for all the gather variants as well. I think just having tests where the position of the prefetch specifier is different should be sufficient.
Yes, that seems fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78674/new/

https://reviews.llvm.org/D78674