[PATCH] D78747: [SveEmitter] Add builtins for compares and ReverseCompare flag.
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 23 13:01:20 PDT 2020
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM with one minor comment
================
Comment at: clang/include/clang/Basic/arm_sve.td:74
//
+// w: vector of element type promoted to 64bits
+// j: element type promoted to 64bits (splat to vector type)
----------------
efriedma wrote:
> Isn't "w" the same as the existing "g"? Or is there some difference I'm missing?
Oh, wait, I see, it keep the sign of the original overload type. Maybe you could clarify the comment a bit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78747/new/
https://reviews.llvm.org/D78747
More information about the cfe-commits
mailing list