[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 23 13:01:13 PDT 2020


efriedma added inline comments.


================
Comment at: clang/lib/Analysis/CFG.cpp:2928
+  // FIXME: This does not find the VLA if it is embedded in other types,
+  // like here: `void (*vla)(int[x]);`
   for (const VariableArrayType* VA = FindVA(VD->getType().getTypePtr());
----------------
You probably want a different example in the FIXME: we don't look in at function arguments when determining if a type is variably modified.  (The rule is written in a sort of weird way in the standard, but essentially, we only need to look at the element type of an array, the pointee of a pointer, and the return type of a function.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77809/new/

https://reviews.llvm.org/D77809





More information about the cfe-commits mailing list