[PATCH] D50078: clang-format: support aligned nested conditionals formatting

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D50078#1999183 <https://reviews.llvm.org/D50078#1999183>, @Typz wrote:

> In D50078#1998578 <https://reviews.llvm.org/D50078#1998578>, @hokein wrote:
>
> > In D50078#1998520 <https://reviews.llvm.org/D50078#1998520>, @Typz wrote:
> >
> > > In D50078#1998398 <https://reviews.llvm.org/D50078#1998398>, @dyung wrote:
> > >
> > > > Hi, this change that you submitted in commit 5daa25fd7a184524759b6ad065a8bd7e95aa149a <https://reviews.llvm.org/rG5daa25fd7a184524759b6ad065a8bd7e95aa149a> seems to be causing the test "Clang-Unit :: Format/./FormatTests.exe/FormatTest.ConfigurableUseOfTab" to randomly fail about 50% of the time on Windows.
> > > >
> > > > Take the most recent 5 runs of the llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast buildbot. Builds #31973 <http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/31973>, 31975 <http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/31975> and 31976 <http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/31976> all failed because of that test failing.
> > > >
> > > > On my local Windows computer, if I build your commit and run the FormatTest unit test multiple times (the same binary without changing anything or rebuilding), that above test fails roughly 50% of the time.
> > > >
> > > > Can you take a look to figure out why your change might be causing this instability?
> > >
> > >
> > > Hi,
> > >  That is very strange indeed, nothing is supposed to be random here...
> > >  I will try to have a look, but I don't have a windows computer to test, and never seen this issue on linux/macos :-/
> >
> >
> > The linux (s390x arch) buildbot is also failing, http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/31811/steps/ninja%20check%201/logs/stdio.
> >  I reverted it in 47ef09e4848a970c530928496b54085cfdba5a76 <https://reviews.llvm.org/rG47ef09e4848a970c530928496b54085cfdba5a76> to make buildbot happy.
>
>
> Unfortunately I don't have access to either an s390x or a windows machine; is there a way to trigger a "private" build on buildbot, to use the same setup/build env ?
>  Or some other way to quickly get the required build env?
>
> (Otherwise, could you please check if adding initialization of ConditionalsLevel to 0 in  constructor of WhitespaceManager::Change class (WhitespaceManager.cpp:43).cpp fixes the issue ?)


I tried adding the fix you suggested to WhitespaceManager.cpp, and unfortunately it does not seem to fix the problem. The test still failed 5/10 times on my machine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50078/new/

https://reviews.llvm.org/D50078