[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

[Valeriy Savchenko via Phabricator via cfe-commits]

vsavchenko marked an inline comment as done.
vsavchenko added inline comments.


================
Comment at: clang/test/Analysis/CheckThatArraySubsciptNodeIsNotCollected.cpp:18-19
+// time to collect redundant nodes. This GC-like mechanism kicks in only when
+// the exploded graph is large enough (>1K nodes). For this reason, 'index'
+// is a global variable, and the sink point is inside of a loop.
+
----------------
NoQ wrote:
> I'm still curious why `index` being global actually matters here. Like, how does it increase the number of nodes in the graph?
It does not simply increase the number of nodes, it increases it by thousands!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78638/new/

https://reviews.llvm.org/D78638