[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

[Sander de Smalen via Phabricator via cfe-commits]

sdesmalen added a comment.

It seems a NVIDIA Developer Program Membership is needed in order to download the TRM. I'm not sure if that is just a matter of creating an account, but without it I can't really verify that the architecture version and the features are correct and complete.



================
Comment at: clang/test/Preprocessor/aarch64-target-features.c:183
 // CHECK-MCPU-A64FX: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8.2a" "-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature" "+crc" "-target-feature" "+crypto" "-target-feature" "+fullfp16" "-target-feature" "+ras" "-target-feature" "+lse" "-target-feature" "+rdm" "-target-feature" "+sve" "-target-feature" "+sha2"
+// CHECK-MCPU-CARMEL: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8.2a" "-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature" "+crc" "-target-feature" "+crypto" "-target-feature" "+fullfp16" "-target-feature" "+ras" "-target-feature" "+lse" "-target-feature" "+rdm" "-target-feature" "+sve" "-target-feature" "+sha2" "-target-feature" "+aes"
 
----------------
This test references unsupported features.


================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:181
+AARCH64_CPU_NAME("carmel", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
+                 (AArch64::AEK_FP16 | AArch64::AEK_SVE))
 // Invalid CPU
----------------
This still references `AEK_SVE`.


================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:980
+      AArch64::AEK_CRC | AArch64::AEK_CRYPTO | AArch64::AEK_FP |
+          AArch64::AEK_SIMD | AArch64::AEK_FP16 | AArch64::AEK_RAS |
+          AArch64::AEK_LSE | AArch64::AEK_SVE | AArch64::AEK_RDM,
----------------
tambre wrote:
> sdesmalen wrote:
> > nit: odd indentation here, have you used clang-format?
> Fixed manually. Using clang-format results in unpleasant formatting similar to "apple-a10" and "apple-a11" above.
Okay, that's fine, thanks for fixing.


================
Comment at: llvm/unittests/Support/TargetParserTest.cpp:1134
                                    AArch64::ArchKind::INVALID, "sve2"));
+  EXPECT_TRUE(
+      testAArch64Extension("carmel", AArch64::ArchKind::INVALID, "fp16"));
----------------
nit: It seems a bit arbitrary to only check for fp16 here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77940/new/

https://reviews.llvm.org/D77940