[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

Thu Apr 23 04:17:36 PDT 2020

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

I agree with the sentiment that it's annoying when clang doesn't just work out of the box. But it will still do, except for asan and profile info etc, for which I think it's reasonable to add to the documentation what the user needs to do. I think the place to do that is https://clang.llvm.org/docs/UsersManual.html#clang-cl (and a release note). It would be great if the doc includes the error message one would get when the link fails, to make it easy to find through web search.

> One last idea is that we could teach LLD to automatically add this directory to library search path, but then users who link with Visual C++ (not many anymore) will run into this as a corner case issue.

I thought about that too, and I think it's a good idea. Having the linker in a toolchain know about the runtime libs seems pretty reasonable I think?

================
Comment at: clang/docs/ReleaseNotes.rst:63
+  clang-cl embedded paths to these libraries in object files, but now the
+  compiler no longer embeds a full path.

----------------
Could this be expanded to a more explain-like-I'm-five style example?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65543/new/

https://reviews.llvm.org/D65543