[PATCH] D78693: Make "#pragma clang attribute" support uninitialized attribute.

[JF Bastien via Phabricator via cfe-commits]

jfb added a comment.

Looks pretty good to me. Not my areas of expertise so I’d like to have others look too. Thanks for doing this!



================
Comment at: clang/test/Parser/pragma-attribute.cpp:190
+#pragma clang attribute pop
+#pragma clang attribute push([[clang::uninitialized]], apply_to = variable) // expected-error {{attribute 'uninitialized' can't be applied to 'variable'}}
+#pragma clang attribute pop
----------------
Should variable work? Since it’s a superset of local it seems like maybe? But then again only local works, so ok not sure. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78693/new/

https://reviews.llvm.org/D78693