[PATCH] D78521: [clangd] Extend dexp to support remote index

Wed Apr 22 12:30:55 PDT 2020

kbobyrev added inline comments.

================
Comment at: clang-tools-extra/clangd/index/remote/Index.proto:37
+message FuzzyFindReply {
+  // FIXME(kirillbobyrev): Convert to Symbol.
+  repeated string symbols = 1;
----------------
sammccall wrote:
> kbobyrev wrote:
> > sammccall wrote:
> > > confused... why not use Symbol now?
> > Couldn't put `Symbol`s into `FuzzyFindReply` for some reason. Clangd behaves really weird with Protobuf inclusions for me... Need to figure out why that happens, but might be me doing something wrong.
> Did you find out? Fixing this isn't a backwards-compatible change, and "this code is broken and I don't know why" isn't a great state for checkin.
> 
> Happy to help but please provide some details.
Yes, it has to do with different code generated by Protobuf and I learned how to discover which API is becoming removed and which is accessible.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78521/new/

https://reviews.llvm.org/D78521