[PATCH] D78649: [clang] Make sure argument expansion locations are correct in presence of predefined buffer

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 22 11:26:11 PDT 2020


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Basic/SourceManager.cpp:1816
+      } else if (IncludeLoc.isValid()) {
+        // If file wasn't included from FID, there is no more files/macros that
+        // may be "contained" in this file.
----------------
wasn't included from FID -> was included but not from FID


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78649/new/

https://reviews.llvm.org/D78649





More information about the cfe-commits mailing list